ghost/core/test/unit/server/services/stripe/billing-portal-manager.test.js (1)

188-189: Strengthen this regression test with call assertions.

On Line 188-Line 189, this validates only the return value. Add API interaction assertions to lock behavior (update attempted, no fallback create).

Suggested test diff

             const result = await manager.createOrUpdateConfiguration('bpc_existing');
             assert.equal(result, 'bpc_existing');
+            sinon.assert.calledOnce(mockApi.updateBillingPortalConfiguration);
+            sinon.assert.notCalled(mockApi.createBillingPortalConfiguration);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/test/unit/server/services/stripe/billing-portal-manager.test.js`
around lines 188 - 189, The test only asserts the return value of
manager.createOrUpdateConfiguration('bpc_existing'); add assertions that the
billing-portal configuration update API was invoked and that the create API was
not called: e.g., assert that the stub/spy for the billing portal
configurations.update method was called once with an object containing id
'bpc_existing' (or the expected params) and assert that the
configurations.create stub/spy was not called; use the existing sinon/sandbox
stubs used in this test file to check calls on the billing portal client so the
test locks behavior to "update attempted, no fallback create."

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

ghost/core/test/unit/server/services/stripe/billing-portal-manager.test.js (1)

176-190: Strengthen this regression test with interaction assertions

Line 188-Line 189 validates the returned ID, but this can still pass if the update path is skipped or create fallback is used accidentally. Add explicit call assertions to lock the intended branch behavior.

Proposed test hardening

         it('returns the passed id when failing with a non-resource based error', async function () {
             mockSettingsCache.get.withArgs('title').returns('Test Site');
             const genericError = new Error('Stripe API error');
             mockApi.updateBillingPortalConfiguration.rejects(genericError);

             const manager = new BillingPortalManager({
                 api: mockApi,
                 models: {Settings: mockSettingsModel},
                 settingsCache: mockSettingsCache
             });
             manager.configure({siteUrl: 'https://example.com'});

             const result = await manager.createOrUpdateConfiguration('bpc_existing');
             assert.equal(result, 'bpc_existing');
+            sinon.assert.calledOnce(mockApi.updateBillingPortalConfiguration);
+            sinon.assert.notCalled(mockApi.createBillingPortalConfiguration);
+            assert.equal(mockApi.updateBillingPortalConfiguration.firstCall.args[0], 'bpc_existing');
         });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/test/unit/server/services/stripe/billing-portal-manager.test.js`
around lines 176 - 190, The test must assert the API interactions to ensure the
update path was exercised; after calling
BillingPortalManager.createOrUpdateConfiguration('bpc_existing') add assertions
that mockApi.updateBillingPortalConfiguration was called once with the existing
id (and expected payload) and that mockApi.createBillingPortalConfiguration was
not called. Locate the test using BillingPortalManager and the
createOrUpdateConfiguration invocation and add these call assertions (e.g.
sinon/assert-style checks) referencing mockApi.updateBillingPortalConfiguration
and mockApi.createBillingPortalConfiguration to lock the intended branch
behavior.